Support for data sources with heterogeneous cell reuse identifiers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier if the default reuse identifier property is nil
|
👍 LGTM |
|
@rafaelwinter Looks good! My only suggestion would be to implement |
| @@ -36,7 +36,7 @@ | |||
| Initializes the data source. | |||
|
|
|||
| @param items The items managed by the data source. | |||
| @param reuseIdentifier The cell reuse identifier. | |||
| @param reuseIdentifier The default cell reuse identifier. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a solution for the case of an implementation that uses more than one reuse identifier on the data source. This happens when the view is composed by heterogeneous cells.
The idea is to use a block that provides the reuse identifier for a cell on the given index path. There are some handy new initializers for this case, that will take the reuse identifier block instead of a single reuse identifier string.